Skip to content

Commit 544300e

Browse files
AndreasMadsenaddaleax
authored andcommitted
async_hooks: require parameter in emitBefore
Using asyncId as the default triggerAsyncId is wrong. The triggerAsyncId can actually never be the asyncId. PR-URL: #14050 Reviewed-By: Trevor Norris <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
1 parent 9f66f19 commit 544300e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

lib/async_hooks.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -377,7 +377,7 @@ function emitHookFactory(symbol, name) {
377377

378378
// Usage: emitBeforeS(asyncId[, triggerAsyncId]). If triggerAsyncId is omitted
379379
// then asyncId will be used instead.
380-
function emitBeforeS(asyncId, triggerAsyncId = asyncId) {
380+
function emitBeforeS(asyncId, triggerAsyncId) {
381381
// CHECK(Number.isSafeInteger(asyncId) && asyncId > 0)
382382
// CHECK(Number.isSafeInteger(triggerAsyncId) && triggerAsyncId > 0)
383383

0 commit comments

Comments
 (0)