Skip to content

Commit 552e25c

Browse files
TrottMyles Borins
authored and
Myles Borins
committed
lib,test: update in preparation for linter update
ESLint 2.9.0 fixes some bugs that resulted in minor issues not being caught by ESLint 2.7.0. Update instances of our code that will be flagged when we upgrade to ESLint 2.9.0. PR-URL: #6498 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
1 parent 037291e commit 552e25c

File tree

3 files changed

+8
-1
lines changed

3 files changed

+8
-1
lines changed

lib/buffer.js

+1
Original file line numberDiff line numberDiff line change
@@ -263,6 +263,7 @@ function byteLength(string, encoding) {
263263
case 'ascii':
264264
case 'binary':
265265
// Deprecated
266+
// eslint-disable-next-line no-fallthrough
266267
case 'raw':
267268
case 'raws':
268269
return len;

lib/readline.js

+1
Original file line numberDiff line numberDiff line change
@@ -977,6 +977,7 @@ exports.emitKeypressEvents = emitKeypressEvents;
977977
*/
978978

979979
// Regexes used for ansi escape code splitting
980+
// eslint-disable-next-line no-control-regex
980981
const metaKeyCodeReAnywhere = /(?:\x1b)([a-zA-Z0-9])/;
981982
const functionKeyCodeReAnywhere = new RegExp('(?:\x1b+)(O|N|\\[|\\[\\[)(?:' + [
982983
'(\\d+)(?:;(\\d+))?([~^$])',

test/parallel/test-http-destroyed-socket-write2.js

+6-1
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,17 @@ server.listen(common.PORT, function() {
2929
switch (er.code) {
3030
// This is the expected case
3131
case 'ECONNRESET':
32-
// On windows this sometimes manifests as ECONNABORTED
32+
break;
33+
34+
// On Windows, this sometimes manifests as ECONNABORTED
3335
case 'ECONNABORTED':
36+
break;
37+
3438
// This test is timing sensitive so an EPIPE is not out of the question.
3539
// It should be infrequent, given the 50 ms timeout, but not impossible.
3640
case 'EPIPE':
3741
break;
42+
3843
default:
3944
assert.strictEqual(er.code,
4045
'ECONNRESET',

0 commit comments

Comments
 (0)