@@ -21,26 +21,21 @@ privileges include but are not limited to:
21
21
* Commit access to the [ nodejs/node] [ ] repository
22
22
* Access to the Node.js continuous integration (CI) jobs
23
23
24
- Modifications of the contents of the nodejs/node repository are made on
25
- a collaborative basis. Anybody with a GitHub account may propose a
26
- modification via pull request and it will be considered by the project
27
- Collaborators .
24
+ Both Collaborators and non-Collaborators may propose changes to the Node.js
25
+ source code. The mechanism to propose such a change is a GitHub pull request.
26
+ Collaborators are responsible for reviewing and merging ( _ landing _ )
27
+ pull requests .
28
28
29
29
At least two Collaborators must approve a pull request before the pull request
30
- lands . (One Collaborator approval is enough if the pull request has been open
30
+ can land . (One Collaborator approval is enough if the pull request has been open
31
31
for more than 7 days.) Approving a pull request indicates that the Collaborator
32
32
accepts responsibility for the change. Approval must be from Collaborators who
33
33
are not authors of the change.
34
34
35
- If one or more Collaborators oppose a proposed change, then the change cannot
36
- be accepted unless:
37
-
38
- * Discussions and/or additional changes result in no Collaborators objecting to
39
- the change. Previously-objecting Collaborators do not necessarily have to
40
- sign off on the change, but they should not be opposed to it.
41
- * The change is escalated to the TSC and the TSC votes to approve the change.
42
- This should only happen if disagreements between Collaborators cannot be
43
- resolved through discussion.
35
+ If a Collaborator opposes a proposed change, then the change cannot land. The
36
+ exception is if the TSC votes to approve the change despite the opposition.
37
+ Usually, involving the TSC is unnecessary. Often, discussions or further changes
38
+ result in Collaborators removing their opposition.
44
39
45
40
See:
46
41
0 commit comments