Skip to content

Commit 557bd86

Browse files
committed
doc: revise Collaborator material in GOVERNANCE.md
* Reduce passive voice * Shorter and simpler sentences PR-URL: #27103 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]>
1 parent 1afec97 commit 557bd86

File tree

1 file changed

+9
-14
lines changed

1 file changed

+9
-14
lines changed

GOVERNANCE.md

+9-14
Original file line numberDiff line numberDiff line change
@@ -21,26 +21,21 @@ privileges include but are not limited to:
2121
* Commit access to the [nodejs/node][] repository
2222
* Access to the Node.js continuous integration (CI) jobs
2323

24-
Modifications of the contents of the nodejs/node repository are made on
25-
a collaborative basis. Anybody with a GitHub account may propose a
26-
modification via pull request and it will be considered by the project
27-
Collaborators.
24+
Both Collaborators and non-Collaborators may propose changes to the Node.js
25+
source code. The mechanism to propose such a change is a GitHub pull request.
26+
Collaborators are responsible for reviewing and merging (_landing_)
27+
pull requests.
2828

2929
At least two Collaborators must approve a pull request before the pull request
30-
lands. (One Collaborator approval is enough if the pull request has been open
30+
can land. (One Collaborator approval is enough if the pull request has been open
3131
for more than 7 days.) Approving a pull request indicates that the Collaborator
3232
accepts responsibility for the change. Approval must be from Collaborators who
3333
are not authors of the change.
3434

35-
If one or more Collaborators oppose a proposed change, then the change cannot
36-
be accepted unless:
37-
38-
* Discussions and/or additional changes result in no Collaborators objecting to
39-
the change. Previously-objecting Collaborators do not necessarily have to
40-
sign off on the change, but they should not be opposed to it.
41-
* The change is escalated to the TSC and the TSC votes to approve the change.
42-
This should only happen if disagreements between Collaborators cannot be
43-
resolved through discussion.
35+
If a Collaborator opposes a proposed change, then the change cannot land. The
36+
exception is if the TSC votes to approve the change despite the opposition.
37+
Usually, involving the TSC is unnecessary. Often, discussions or further changes
38+
result in Collaborators removing their opposition.
4439

4540
See:
4641

0 commit comments

Comments
 (0)