Skip to content

Commit 56354d4

Browse files
addaleaxTrott
authored andcommitted
build: run flaky tests in Travis
Skipping flaky tests in CI is an anti-pattern that should be avoided, as we do in our ownCI. Failing flaky tests don’t need to be blockers for a green CI result, but they should be run and reported *somehow*. PR-URL: #27158 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
1 parent 9b859f5 commit 56354d4

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.travis.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -65,4 +65,4 @@ jobs:
6565
- make -j2 > /dev/null
6666
- make -j1 build-addons build-js-native-api-tests build-node-api-tests > /dev/null
6767
script:
68-
- JOBS=2 FLAKY_TESTS=skip make -s -j1 V= test-ci | grep -F -e "---" -e "..." -v
68+
- JOBS=2 FLAKY_TESTS=dontcare make -s -j1 V= test-ci | grep -F -e "---" -e "..." -v

0 commit comments

Comments
 (0)