Skip to content

Commit 56b193a

Browse files
edsadrMylesBorins
authored andcommitted
test: improve code in test-vm-preserves-property
* use const instead of var * use assert.strictEqual instead assert.equal PR-URL #10428 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
1 parent 8a26ba1 commit 56b193a

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed
+11-11
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,25 @@
11
'use strict';
22

33
require('../common');
4-
var assert = require('assert');
4+
const assert = require('assert');
55

6-
var vm = require('vm');
6+
const vm = require('vm');
77

8-
var x = {};
8+
const x = {};
99
Object.defineProperty(x, 'prop', {
1010
configurable: false,
1111
enumerable: false,
1212
writable: false,
1313
value: 'val'
1414
});
15-
var o = vm.createContext(x);
15+
const o = vm.createContext(x);
1616

17-
var code = 'Object.getOwnPropertyDescriptor(this, "prop")';
18-
var res = vm.runInContext(code, o, 'test');
17+
const code = 'Object.getOwnPropertyDescriptor(this, "prop")';
18+
const res = vm.runInContext(code, o, 'test');
1919

2020
assert(res);
21-
assert.equal(typeof res, 'object');
22-
assert.equal(res.value, 'val');
23-
assert.equal(res.configurable, false, 'should not be configurable');
24-
assert.equal(res.enumerable, false, 'should not be enumerable');
25-
assert.equal(res.writable, false, 'should not be writable');
21+
assert.strictEqual(typeof res, 'object');
22+
assert.strictEqual(res.value, 'val');
23+
assert.strictEqual(res.configurable, false, 'should not be configurable');
24+
assert.strictEqual(res.enumerable, false, 'should not be enumerable');
25+
assert.strictEqual(res.writable, false, 'should not be writable');

0 commit comments

Comments
 (0)