Skip to content

Commit 56c4365

Browse files
targosnodejs-github-bot
authored andcommitted
deps: fix V8 build on Windows with MSVC
PR-URL: #45579 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 51ab98c commit 56c4365

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.3',
39+
'v8_embedder_string': '-node.4',
4040

4141
##### V8 defaults for Node.js #####
4242

deps/v8/src/wasm/function-body-decoder-impl.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -2290,7 +2290,7 @@ class WasmDecoder : public Decoder {
22902290
}
22912291

22922292
// TODO(clemensb): This is only used by the interpreter; move there.
2293-
V8_EXPORT_PRIVATE std::pair<uint32_t, uint32_t> StackEffect(const byte* pc) {
2293+
std::pair<uint32_t, uint32_t> StackEffect(const byte* pc) {
22942294
WasmOpcode opcode = static_cast<WasmOpcode>(*pc);
22952295
// Handle "simple" opcodes with a fixed signature first.
22962296
const FunctionSig* sig = WasmOpcodes::Signature(opcode);

0 commit comments

Comments
 (0)