File tree 2 files changed +9
-18
lines changed
2 files changed +9
-18
lines changed Original file line number Diff line number Diff line change 440
440
// of possible types.
441
441
const versionTypes = icu . getVersion ( ) . split ( ',' ) ;
442
442
443
- function makeGetter ( name ) {
444
- return ( ) => {
445
- // With an argument, getVersion(type) returns
446
- // the actual version string.
447
- const version = icu . getVersion ( name ) ;
448
- // Replace the current getter with a new property.
449
- delete process . versions [ name ] ;
450
- Object . defineProperty ( process . versions , name , {
451
- value : version ,
452
- writable : false ,
453
- enumerable : true
454
- } ) ;
455
- return version ;
456
- } ;
457
- }
458
-
459
443
for ( var n = 0 ; n < versionTypes . length ; n ++ ) {
460
444
var name = versionTypes [ n ] ;
445
+ const version = icu . getVersion ( name ) ;
461
446
Object . defineProperty ( process . versions , name , {
462
- configurable : true ,
447
+ writable : false ,
463
448
enumerable : true ,
464
- get : makeGetter ( name )
449
+ value : version
465
450
} ) ;
466
451
}
467
452
}
Original file line number Diff line number Diff line change @@ -32,3 +32,9 @@ assert(commonTemplate.test(process.versions.zlib));
32
32
assert ( / ^ \d + \. \d + \. \d + (?: \. \d + ) ? (?: \( c a n d i d a t e \) ) ? $ /
33
33
. test ( process . versions . v8 ) ) ;
34
34
assert ( / ^ \d + $ / . test ( process . versions . modules ) ) ;
35
+
36
+ for ( let i = 0 ; i < expected_keys . length ; i ++ ) {
37
+ const key = expected_keys [ i ] ;
38
+ const descriptor = Object . getOwnPropertyDescriptor ( process . versions , key ) ;
39
+ assert . strictEqual ( descriptor . writable , false ) ;
40
+ }
You can’t perform that action at this time.
0 commit comments