Skip to content

Commit 587c905

Browse files
Eugene Ostroukhovaddaleax
Eugene Ostroukhov
authored andcommitted
test: check uv_ip4_addr return value
Fixes Coverity errors. PR-URL: #13878 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
1 parent 46cc80a commit 587c905

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

test/cctest/test_inspector_socket.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -370,7 +370,7 @@ class InspectorSocketTest : public ::testing::Test {
370370
sockaddr_in addr;
371371
uv_tcp_init(&loop, &server);
372372
uv_tcp_init(&loop, &client_socket);
373-
uv_ip4_addr("127.0.0.1", PORT, &addr);
373+
GTEST_ASSERT_EQ(0, uv_ip4_addr("127.0.0.1", PORT, &addr));
374374
uv_tcp_bind(&server, reinterpret_cast<const struct sockaddr*>(&addr), 0);
375375
GTEST_ASSERT_EQ(0, uv_listen(reinterpret_cast<uv_stream_t*>(&server),
376376
1, on_new_connection));

test/cctest/test_inspector_socket_server.cc

+5-4
Original file line numberDiff line numberDiff line change
@@ -194,10 +194,11 @@ class SocketWrapper {
194194
contents_.clear();
195195
uv_tcp_init(loop_, &socket_);
196196
sockaddr_in addr;
197-
uv_ip4_addr(host.c_str(), port, &addr);
198-
int err = uv_tcp_connect(&connect_, &socket_,
199-
reinterpret_cast<const sockaddr*>(&addr),
200-
ConnectionMustFail_);
197+
int err = uv_ip4_addr(host.c_str(), port, &addr);
198+
ASSERT_EQ(0, err);
199+
err = uv_tcp_connect(&connect_, &socket_,
200+
reinterpret_cast<const sockaddr*>(&addr),
201+
ConnectionMustFail_);
201202
ASSERT_EQ(0, err);
202203
SPIN_WHILE(!connection_failed_)
203204
uv_read_start(reinterpret_cast<uv_stream_t*>(&socket_), AllocCallback,

0 commit comments

Comments
 (0)