url: declare iterator inside loop

Refs: #30281 (comment)

PR-URL: #30509
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>

Author: trivikr

lib/url.js

@@ -166,8 +166,7 @@ Url.prototype.parse = function parse(url, parseQueryString, slashesDenoteHost) {
   let end = -1;
   let rest = '';
   let lastPos = 0;
-  let i = 0;
-  for (let inWs = false, split = false; i < url.length; ++i) {
+  for (let i = 0, inWs = false, split = false; i < url.length; ++i) {
     const code = url.charCodeAt(i);
 
     // Find first and last non-whitespace characters for trimming
@@ -299,7 +298,7 @@ Url.prototype.parse = function parse(url, parseQueryString, slashesDenoteHost) {
     let hostEnd = -1;
     let atSign = -1;
     let nonHost = -1;
-    for (i = 0; i < rest.length; ++i) {
+    for (let i = 0; i < rest.length; ++i) {
       switch (rest.charCodeAt(i)) {
         case CHAR_TAB:
         case CHAR_LINE_FEED:
@@ -415,7 +414,7 @@ Url.prototype.parse = function parse(url, parseQueryString, slashesDenoteHost) {
 
   let questionIdx = -1;
   let hashIdx = -1;
-  for (i = 0; i < rest.length; ++i) {
+  for (let i = 0; i < rest.length; ++i) {
     const code = rest.charCodeAt(i);
     if (code === CHAR_HASH) {
       this.hash = rest.slice(i);