Skip to content

Commit 5ab4471

Browse files
evanlucasFishrock123
authored andcommitted
build,tools: do not force codesign prefix
Allow passing the prefix in via the PKGDIR env var. This will allow us to use this same script to codesign the binary tarball. PR-URL: #14179 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent def98c6 commit 5ab4471

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

Makefile

+2-1
Original file line numberDiff line numberDiff line change
@@ -702,7 +702,8 @@ $(PKG): release-only
702702
--release-urlbase=$(RELEASE_URLBASE) \
703703
$(CONFIG_FLAGS) $(BUILD_RELEASE_FLAGS)
704704
$(MAKE) install V=$(V) DESTDIR=$(PKGDIR)
705-
SIGN="$(CODESIGN_CERT)" PKGDIR="$(PKGDIR)" bash tools/osx-codesign.sh
705+
SIGN="$(CODESIGN_CERT)" PKGDIR="$(PKGDIR)/usr/local" bash \
706+
tools/osx-codesign.sh
706707
cat tools/osx-pkg.pmdoc/index.xml.tmpl \
707708
| sed -E "s/\\{nodeversion\\}/$(FULLVERSION)/g" \
708709
| sed -E "s/\\{npmversion\\}/$(NPMVERSION)/g" \

tools/osx-codesign.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,4 +8,4 @@ if [ "X$SIGN" == "X" ]; then
88
exit 0
99
fi
1010

11-
codesign -s "$SIGN" "$PKGDIR"/usr/local/bin/node
11+
codesign -s "$SIGN" "$PKGDIR"/bin/node

0 commit comments

Comments
 (0)