Skip to content

Commit 5c2e061

Browse files
StefanStojanovicruyadorno
authored andcommitted
deps: define V8_PRESERVE_MOST as no-op on Windows
It's causing linker errors with node.lib in node-gyp and potentially breaks other 3rd party tools PR-URL: #56238 Refs: #55784 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
1 parent 9436c3c commit 5c2e061

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.21',
39+
'v8_embedder_string': '-node.22',
4040

4141
##### V8 defaults for Node.js #####
4242

deps/v8/include/v8config.h

+4
Original file line numberDiff line numberDiff line change
@@ -549,11 +549,15 @@ path. Add it with -I<path> to the command line
549549
// functions.
550550
// Use like:
551551
// V8_NOINLINE V8_PRESERVE_MOST void UnlikelyMethod();
552+
#if V8_OS_WIN
553+
# define V8_PRESERVE_MOST
554+
#else
552555
#if V8_HAS_ATTRIBUTE_PRESERVE_MOST
553556
# define V8_PRESERVE_MOST __attribute__((preserve_most))
554557
#else
555558
# define V8_PRESERVE_MOST /* NOT SUPPORTED */
556559
#endif
560+
#endif
557561

558562

559563
// A macro (V8_DEPRECATED) to mark classes or functions as deprecated.

0 commit comments

Comments
 (0)