Skip to content

Commit 5c2ed2e

Browse files
thefourtheyeMyles Borins
authored and
Myles Borins
committed
build: make node-gyp output silent
As it is, node-gyp produces a lot of build related verbose messages. Latest node-gyp upgrade allows us to specify --silent flag to suppress those messages. Except for CI, addons build will run silently. PR-URL: #8990 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Ilkka Myller <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
1 parent 54def06 commit 5c2ed2e

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

Makefile

+5-1
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ PREFIX ?= /usr/local
88
FLAKY_TESTS ?= run
99
TEST_CI_ARGS ?=
1010
STAGINGSERVER ?= node-www
11+
LOGLEVEL ?= silent
1112
OSTYPE := $(shell uname -s | tr '[A-Z]' '[a-z]')
1213

1314
ifdef JOBS
@@ -163,7 +164,8 @@ test/addons/.buildstamp: config.gypi \
163164
# Cannot use $(wildcard test/addons/*/) here, it's evaluated before
164165
# embedded addons have been generated from the documentation.
165166
for dirname in test/addons/*/; do \
166-
$(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp rebuild \
167+
echo "\nRunning addons test $$PWD/$$dirname" ; \
168+
$(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp --loglevel=$(LOGLEVEL) rebuild \
167169
--python="$(PYTHON)" \
168170
--directory="$$PWD/$$dirname" \
169171
--nodedir="$$PWD" || exit 1 ; \
@@ -193,6 +195,7 @@ CI_NATIVE_SUITES := addons
193195
CI_JS_SUITES := doctool inspector known_issues message parallel pseudo-tty sequential
194196

195197
# Build and test addons without building anything else
198+
test-ci-native: LOGLEVEL := info
196199
test-ci-native: | test/addons/.buildstamp
197200
$(PYTHON) tools/test.py $(PARALLEL_ARGS) -p tap --logfile test.tap \
198201
--mode=release --flaky-tests=$(FLAKY_TESTS) \
@@ -204,6 +207,7 @@ test-ci-js:
204207
--mode=release --flaky-tests=$(FLAKY_TESTS) \
205208
$(TEST_CI_ARGS) $(CI_JS_SUITES)
206209

210+
test-ci: LOGLEVEL := info
207211
test-ci: | build-addons
208212
out/Release/cctest --gtest_output=tap:cctest.tap
209213
$(PYTHON) tools/test.py $(PARALLEL_ARGS) -p tap --logfile test.tap \

0 commit comments

Comments
 (0)