Skip to content

Commit 5cc24e6

Browse files
gengjiawentargos
authored andcommitted
deps: V8: cherry-pick 9a607043cb31
Original commit message: [compiler] Gracefully handle an unsupported situation ... by skipping the optimization instead of CHECK-failing. Bug: v8:12188 Change-Id: I6709bf1c55506f3d12886efbfbb9934788cd02ce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3148132 Auto-Submit: Georg Neis <[email protected]> Commit-Queue: Jakob Gruber <[email protected]> Reviewed-by: Jakob Gruber <[email protected]> Cr-Commit-Position: refs/heads/main@{#76741} Refs: v8/v8@9a60704 PR-URL: #40046 Fixes: #40030 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]>
1 parent 8de5eb8 commit 5cc24e6

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.10',
39+
'v8_embedder_string': '-node.11',
4040

4141
##### V8 defaults for Node.js #####
4242

deps/v8/src/objects/lookup.cc

+2-2
Original file line numberDiff line numberDiff line change
@@ -1527,8 +1527,8 @@ base::Optional<PropertyCell> ConcurrentLookupIterator::TryGetPropertyCell(
15271527
DisallowGarbageCollection no_gc;
15281528

15291529
Map holder_map = holder->map();
1530-
CHECK(!holder_map.is_access_check_needed());
1531-
CHECK(!holder_map.has_named_interceptor());
1530+
if (holder_map.is_access_check_needed()) return {};
1531+
if (holder_map.has_named_interceptor()) return {};
15321532

15331533
GlobalDictionary dict = holder->global_dictionary(kAcquireLoad);
15341534
base::Optional<PropertyCell> cell =

0 commit comments

Comments
 (0)