Skip to content

Commit 5cfab14

Browse files
Trotttargos
authored andcommitted
test: remove common.hasTracing
`common.hasTracing` is only used in one place. `common` is bloated so let's move that to the one test that uses it. `hasTracing` is undocumented so there's no need to remove it from the README file as it's not there in the first place. Similarly, it's not included in the .mjs version of the `common` file. PR-URL: #22250 Reviewed-By: Bryan English <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: George Adams <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
1 parent 03b8258 commit 5cfab14

File tree

2 files changed

+1
-8
lines changed

2 files changed

+1
-8
lines changed

test/common/index.js

-7
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ const { exec, execSync, spawn, spawnSync } = require('child_process');
3030
const stream = require('stream');
3131
const util = require('util');
3232
const Timer = process.binding('timer_wrap').Timer;
33-
const { hasTracing } = process.binding('config');
3433
const { fixturesDir } = require('./fixtures');
3534
const tmpdir = require('./tmpdir');
3635

@@ -227,12 +226,6 @@ Object.defineProperty(exports, 'hasCrypto', {
227226
}
228227
});
229228

230-
Object.defineProperty(exports, 'hasTracing', {
231-
get: function() {
232-
return Boolean(hasTracing);
233-
}
234-
});
235-
236229
Object.defineProperty(exports, 'hasFipsCrypto', {
237230
get: function() {
238231
return exports.hasCrypto && require('crypto').fips;

test/parallel/test-trace-events-api.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
const common = require('../common');
55

6-
if (!common.hasTracing)
6+
if (!process.binding('config').hasTracing)
77
common.skip('missing trace events');
88
if (!common.isMainThread)
99
common.skip('process.chdir is not available in Workers');

0 commit comments

Comments
 (0)