Skip to content

Commit 5d6d3ee

Browse files
bengljasnell
authored andcommitted
doc: clarify "Reviewed-By" iff "LGTM"
As per conversation with @Trott, make it clear that Reviewed-By lines should only be added for collaborators who've actually put a LGTM on the PR. PR-URL: #7183 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: JacksonTian - Jackson Tian <[email protected]>
1 parent 9a0d26f commit 5d6d3ee

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

doc/onboarding.md

+1
Original file line numberDiff line numberDiff line change
@@ -169,6 +169,7 @@ Landing a PR
169169
* `Reviewed-By: human <email>`
170170
* Easiest to use `git log` then do a search
171171
* (`/Name` + `enter` (+ `n` as much as you need to) in vim)
172+
* Only include collaborators who have commented "LGTM"
172173
* `PR-URL: <full-pr-url>`
173174
* `git push upstream master`
174175
* close the original PR with "Landed in `<commit hash>`".

0 commit comments

Comments
 (0)