Skip to content

Commit 5e1ceaa

Browse files
Trotttargos
authored andcommitted
build: remove redundant Makefile target
The only target that uses the `tools/doc/node_modules/js-yaml/package.json` target is `doc-only`. As a result of a recent change, it has `tools/doc/node_modules` as a prerequisite, which does the exact same npm install as `tools/doc/node_modules/js-yaml/package.json`. Remove `tools/doc/node_modules/js-yaml/package.json` as unnecessary. PR-URL: #21915 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
1 parent 3213c09 commit 5e1ceaa

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

Makefile

-8
Original file line numberDiff line numberDiff line change
@@ -619,11 +619,6 @@ apiassets = $(subst api_assets,api/assets,$(addprefix out/,$(wildcard doc/api_as
619619
.PHONY: doc-only
620620
doc-only: tools/doc/node_modules \
621621
$(apidoc_dirs) $(apiassets) ## Builds the docs with the local or the global Node.js binary.
622-
# If it's a source tarball, assets are already in doc/api/assets,
623-
# no need to install anything, we have already copied the docs over
624-
if [ ! -d doc/api/assets ]; then \
625-
$(MAKE) tools/doc/node_modules/js-yaml/package.json; \
626-
fi;
627622
@$(MAKE) out/doc/api/all.html out/doc/api/all.json
628623

629624
.PHONY: doc
@@ -662,9 +657,6 @@ available-node = \
662657
run-npm-install = $(PWD)/$(NPM) install --production --no-package-lock
663658
run-npm-ci = $(PWD)/$(NPM) ci
664659

665-
tools/doc/node_modules/js-yaml/package.json:
666-
cd tools/doc && $(call available-node,$(run-npm-install))
667-
668660
gen-json = tools/doc/generate.js --format=json $< > $@
669661
gen-html = tools/doc/generate.js --node-version=$(FULLVERSION) --format=html \
670662
--analytics=$(DOCS_ANALYTICS) $< > $@

0 commit comments

Comments
 (0)