Skip to content

Commit 5e3c679

Browse files
codegagancodebytere
authored andcommitted
http2: elevate v8 namespaces of repeated references
PR-URL: #24453 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
1 parent 53973fd commit 5e3c679

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

src/node_http2.cc

+6-4
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,13 @@
1212
namespace node {
1313

1414
using v8::ArrayBuffer;
15+
using v8::ArrayBufferCreationMode;
1516
using v8::Boolean;
1617
using v8::Context;
1718
using v8::Float64Array;
1819
using v8::Function;
1920
using v8::Integer;
21+
using v8::NewStringType;
2022
using v8::Number;
2123
using v8::ObjectTemplate;
2224
using v8::String;
@@ -1411,11 +1413,11 @@ void Http2Session::HandleAltSvcFrame(const nghttp2_frame* frame) {
14111413
Integer::New(isolate, id),
14121414
String::NewFromOneByte(isolate,
14131415
altsvc->origin,
1414-
v8::NewStringType::kNormal,
1416+
NewStringType::kNormal,
14151417
altsvc->origin_len).ToLocalChecked(),
14161418
String::NewFromOneByte(isolate,
14171419
altsvc->field_value,
1418-
v8::NewStringType::kNormal,
1420+
NewStringType::kNormal,
14191421
altsvc->field_value_len).ToLocalChecked(),
14201422
};
14211423

@@ -1445,7 +1447,7 @@ void Http2Session::HandleOriginFrame(const nghttp2_frame* frame) {
14451447
argv[j++] =
14461448
String::NewFromOneByte(isolate,
14471449
entry.origin,
1448-
v8::NewStringType::kNormal,
1450+
NewStringType::kNormal,
14491451
entry.origin_len).ToLocalChecked();
14501452
}
14511453
if (j > 0)
@@ -2330,7 +2332,7 @@ void HttpErrorString(const FunctionCallbackInfo<Value>& args) {
23302332
String::NewFromOneByte(
23312333
env->isolate(),
23322334
reinterpret_cast<const uint8_t*>(nghttp2_strerror(val)),
2333-
v8::NewStringType::kInternalized).ToLocalChecked());
2335+
NewStringType::kInternalized).ToLocalChecked());
23342336
}
23352337

23362338

0 commit comments

Comments
 (0)