Skip to content

Commit 5e588c1

Browse files
committed
test: fixup failing test/internet/test-dns.js
The `ttl` for the `nodejs.org` DNS record is returning `0` currently. The test checks for `> 0`, causing the test to fail. Signed-off-by: James M Snell <[email protected]> PR-URL: #38241 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
1 parent 9440565 commit 5e588c1

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

Diff for: test/internet/test-dns.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ TEST(async function test_resolve4_ttl(done) {
9191
assert.strictEqual(typeof item, 'object');
9292
assert.strictEqual(typeof item.ttl, 'number');
9393
assert.strictEqual(typeof item.address, 'string');
94-
assert.ok(item.ttl > 0);
94+
assert.ok(item.ttl >= 0);
9595
assert.ok(isIPv4(item.address));
9696
}
9797
}
@@ -119,7 +119,7 @@ TEST(async function test_resolve6_ttl(done) {
119119
assert.strictEqual(typeof item, 'object');
120120
assert.strictEqual(typeof item.ttl, 'number');
121121
assert.strictEqual(typeof item.address, 'string');
122-
assert.ok(item.ttl > 0);
122+
assert.ok(item.ttl >= 0);
123123
assert.ok(isIPv6(item.address));
124124
}
125125
}

0 commit comments

Comments
 (0)