Skip to content

Commit 5f05cc1

Browse files
committed
deps: disable V8 concurrent sparkplug compilation
It introduces process hangs on some platforms because Node.js doesn't tear down V8 correctly. Disable it while we work on a solution. Refs: #47297 Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902 PR-URL: #47450 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> PR-URL: #49639 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
1 parent 42cd952 commit 5f05cc1

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.2',
39+
'v8_embedder_string': '-node.3',
4040

4141
##### V8 defaults for Node.js #####
4242

deps/v8/src/flags/flag-definitions.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -892,7 +892,7 @@ DEFINE_BOOL(baseline_batch_compilation, true, "batch compile Sparkplug code")
892892
DEFINE_BOOL_READONLY(concurrent_sparkplug, false,
893893
"compile Sparkplug code in a background thread")
894894
#else
895-
DEFINE_BOOL(concurrent_sparkplug, ENABLE_SPARKPLUG_BY_DEFAULT,
895+
DEFINE_BOOL(concurrent_sparkplug, false,
896896
"compile Sparkplug code in a background thread")
897897
DEFINE_WEAK_IMPLICATION(future, concurrent_sparkplug)
898898
DEFINE_NEG_IMPLICATION(predictable, concurrent_sparkplug)

0 commit comments

Comments
 (0)