Skip to content

Commit 5f79448

Browse files
danbevMylesBorins
authored andcommitted
test: fix truncation of argv
Currently argv_[1] and argv_[2] are getting truncated by one character because of an incorrect addition of one to account for the null character. I only noticed this when working on #12087, but that fix will probably not get included in favor of a JavaScript test so I'm adding this separate commit for it. Refs: #12087 Backport-PR-URL: #18113 PR-URL: #12110 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
1 parent c64a73b commit 5f79448

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

test/cctest/node_test_fixture.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ struct Argv {
3434
snprintf(argv_[0], prog_len, "%s", prog);
3535
snprintf(argv_[0] + prog_len, arg1_len, "%s", arg1);
3636
snprintf(argv_[0] + prog_len + arg1_len, arg2_len, "%s", arg2);
37-
argv_[1] = argv_[0] + prog_len + 1;
38-
argv_[2] = argv_[0] + prog_len + arg1_len + 1;
37+
argv_[1] = argv_[0] + prog_len;
38+
argv_[2] = argv_[0] + prog_len + arg1_len;
3939
}
4040

4141
~Argv() {

0 commit comments

Comments
 (0)