Skip to content

Commit 5fe5fa2

Browse files
bnoordhuisFishrock123
authored andcommitted
test: make addon testing part of make test
Otherwise it's too easy to miss breaking changes to node.h and other public headers until the CI catches them. `vcbuild test` tests addons so there is precedence. PR-URL: #6232 Reviewed-By: Johan Bergström <[email protected]>
1 parent 457d12a commit 5fe5fa2

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

Makefile

+6-3
Original file line numberDiff line numberDiff line change
@@ -114,9 +114,9 @@ v8:
114114
tools/make-v8.sh v8
115115
$(MAKE) -C deps/v8 $(V8_ARCH) $(V8_BUILD_OPTIONS)
116116

117-
test: | cctest # Depends on 'all'.
117+
test: | build-addons cctest # Both targets depend on 'all'.
118118
$(PYTHON) tools/test.py --mode=release -J \
119-
doctool message parallel sequential
119+
addon doctool message parallel sequential
120120
$(MAKE) lint
121121

122122
test-parallel: all
@@ -141,7 +141,10 @@ ADDONS_BINDING_GYPS := \
141141
$(wildcard test/addons/*/binding.gyp))
142142

143143
# Implicitly depends on $(NODE_EXE), see the build-addons rule for rationale.
144-
test/addons/.buildstamp: $(ADDONS_BINDING_GYPS) | test/addons/.docbuildstamp
144+
test/addons/.buildstamp: $(ADDONS_BINDING_GYPS) \
145+
deps/uv/include/*.h deps/v8/include/*.h \
146+
src/node.h src/node_buffer.h src/node_object_wrap.h \
147+
| test/addons/.docbuildstamp
145148
# Cannot use $(wildcard test/addons/*/) here, it's evaluated before
146149
# embedded addons have been generated from the documentation.
147150
for dirname in test/addons/*/; do \

0 commit comments

Comments
 (0)