Skip to content

Commit 60efc5f

Browse files
cclausstargos
authored andcommitted
deps: V8: cherry-pick e3d7f8a
Original commit message: [build] update gen-postmortem-metadata for Python 3 This change makes the code compatible with both Python 2 and Python 3. Change-Id: I99d68af9c3163607c3a2fdbafac339a98b7471e4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1751331 Commit-Queue: Yang Guo <[email protected]> Reviewed-by: Yang Guo <[email protected]> Cr-Commit-Position: refs/heads/master@{#63207} Refs: v8/v8@e3d7f8a Backport-PR-URL: #29241 PR-URL: #29105 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Rich Trott <[email protected]>
1 parent d1bedbe commit 60efc5f

File tree

2 files changed

+3
-7
lines changed

2 files changed

+3
-7
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838

3939
# Reset this number to 0 on major V8 upgrades.
4040
# Increment by one for each non-official patch applied to deps/v8.
41-
'v8_embedder_string': '-node.10',
41+
'v8_embedder_string': '-node.11',
4242

4343
##### V8 defaults for Node.js #####
4444

deps/v8/tools/gen-postmortem-metadata.py

+2-6
Original file line numberDiff line numberDiff line change
@@ -653,9 +653,7 @@ def emit_config():
653653

654654
out.write('/* class type information */\n');
655655
consts = [];
656-
keys = typeclasses.keys();
657-
keys.sort();
658-
for typename in keys:
656+
for typename in sorted(typeclasses):
659657
klass = typeclasses[typename];
660658
consts.append({
661659
'name': 'type_%s__%s' % (klass, typename),
@@ -666,9 +664,7 @@ def emit_config():
666664

667665
out.write('/* class hierarchy information */\n');
668666
consts = [];
669-
keys = klasses.keys();
670-
keys.sort();
671-
for klassname in keys:
667+
for klassname in sorted(klasses):
672668
pklass = klasses[klassname]['parent'];
673669
bklass = get_base_class(klassname);
674670
if (bklass != 'Object'):

0 commit comments

Comments
 (0)