Skip to content

Commit 610297e

Browse files
TrottBethGriggs
authored andcommitted
doc: improve best practices in onboarding-extras
PR-URL: #19315 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
1 parent afcf059 commit 610297e

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

doc/onboarding-extras.md

+3-6
Original file line numberDiff line numberDiff line change
@@ -130,10 +130,7 @@ to update from nodejs/node:
130130
* `git remote update -p` OR `git fetch --all` (I prefer the former)
131131
* `git merge --ff-only upstream/master` (or `REMOTENAME/BRANCH`)
132132

133+
## Best practices
133134

134-
## best practices
135-
136-
* commit often, out to your github fork (origin), open a PR
137-
* when making PRs make sure to spend time on the description:
138-
* every moment you spend writing a good description quarters the amount of time it takes to understand your code.
139-
* usually prefer to only squash at the *end* of your work, depends on the change
135+
* When making PRs, spend time writing a thorough description.
136+
* Usually only squash at the end of your work.

0 commit comments

Comments
 (0)