Skip to content

Commit 61a1c43

Browse files
richardlaumarco-ippolito
authored andcommitted
tools: fix skip detection of test runner output
Fix the Python test harness so that it no longer treats the `# skipped` part of the summary at the end of the built-in test runner output as marking the test as skipped. PR-URL: #53545 Fixes: #50346 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
1 parent 0d69ce3 commit 61a1c43

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tools/test.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ def get_module(name, path):
8383

8484

8585
logger = logging.getLogger('testrunner')
86-
skip_regex = re.compile(r'# SKIP\S*\s+(.*)', re.IGNORECASE)
86+
skip_regex = re.compile(r'(?:\d+\.\.\d+|ok|not ok).*# SKIP\S*\s+(.*)', re.IGNORECASE)
8787

8888
VERBOSE = False
8989

0 commit comments

Comments
 (0)