Skip to content

Commit 64cc234

Browse files
lpincatargos
authored andcommitted
test: use emitter.listenerCount() in test-http-connect
Use `emitter.listenerCount()` instead of the `length` property of the array returned by `emitter.listeners()`. PR-URL: #26031 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
1 parent 32e6bb3 commit 64cc234

File tree

1 file changed

+13
-13
lines changed

1 file changed

+13
-13
lines changed

test/parallel/test-http-connect.js

+13-13
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,11 @@ server.on('connect', common.mustCall((req, socket, firstBodyChunk) => {
3131
assert.strictEqual(req.url, 'google.com:443');
3232

3333
// Make sure this socket has detached.
34-
assert.strictEqual(socket.listeners('close').length, 0);
35-
assert.strictEqual(socket.listeners('drain').length, 0);
36-
assert.strictEqual(socket.listeners('data').length, 0);
37-
assert.strictEqual(socket.listeners('end').length, 1);
38-
assert.strictEqual(socket.listeners('error').length, 0);
34+
assert.strictEqual(socket.listenerCount('close'), 0);
35+
assert.strictEqual(socket.listenerCount('drain'), 0);
36+
assert.strictEqual(socket.listenerCount('data'), 0);
37+
assert.strictEqual(socket.listenerCount('end'), 1);
38+
assert.strictEqual(socket.listenerCount('error'), 0);
3939

4040
socket.write('HTTP/1.1 200 Connection established\r\n\r\n');
4141

@@ -72,14 +72,14 @@ server.listen(0, common.mustCall(() => {
7272
assert(!socket.ondata);
7373
assert(!socket.onend);
7474
assert.strictEqual(socket._httpMessage, null);
75-
assert.strictEqual(socket.listeners('connect').length, 0);
76-
assert.strictEqual(socket.listeners('data').length, 0);
77-
assert.strictEqual(socket.listeners('drain').length, 0);
78-
assert.strictEqual(socket.listeners('end').length, 1);
79-
assert.strictEqual(socket.listeners('free').length, 0);
80-
assert.strictEqual(socket.listeners('close').length, 0);
81-
assert.strictEqual(socket.listeners('error').length, 0);
82-
assert.strictEqual(socket.listeners('agentRemove').length, 0);
75+
assert.strictEqual(socket.listenerCount('connect'), 0);
76+
assert.strictEqual(socket.listenerCount('data'), 0);
77+
assert.strictEqual(socket.listenerCount('drain'), 0);
78+
assert.strictEqual(socket.listenerCount('end'), 1);
79+
assert.strictEqual(socket.listenerCount('free'), 0);
80+
assert.strictEqual(socket.listenerCount('close'), 0);
81+
assert.strictEqual(socket.listenerCount('error'), 0);
82+
assert.strictEqual(socket.listenerCount('agentRemove'), 0);
8383

8484
let data = firstBodyChunk.toString();
8585
socket.on('data', (buf) => {

0 commit comments

Comments
 (0)