Skip to content

Commit 65924c7

Browse files
danbevtargos
authored andcommitted
src: remove unused fields isolate_
Currently the following compiler warnings are generated: In file included from ../src/node_platform.cc:1: ../src/node_platform.h:83:16: warning: private field 'isolate_' is not used [-Wunused-private-field] v8::Isolate* isolate_; ^ 1 warning generated. This commit removes these unused private member. PR-URL: #20876 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: John-David Dalton <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
1 parent de7403f commit 65924c7

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

src/node_platform.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ size_t BackgroundTaskRunner::NumberOfAvailableBackgroundThreads() const {
6565

6666
PerIsolatePlatformData::PerIsolatePlatformData(
6767
v8::Isolate* isolate, uv_loop_t* loop)
68-
: isolate_(isolate), loop_(loop) {
68+
: loop_(loop) {
6969
flush_tasks_ = new uv_async_t();
7070
CHECK_EQ(0, uv_async_init(loop, flush_tasks_, FlushTasks));
7171
flush_tasks_->data = static_cast<void*>(this);

src/node_platform.h

-1
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,6 @@ class PerIsolatePlatformData :
8080
static void RunForegroundTask(uv_timer_t* timer);
8181

8282
int ref_count_ = 1;
83-
v8::Isolate* isolate_;
8483
uv_loop_t* const loop_;
8584
uv_async_t* flush_tasks_ = nullptr;
8685
TaskQueue<v8::Task> foreground_tasks_;

0 commit comments

Comments
 (0)