Skip to content

Commit 663cfbc

Browse files
indutnyMyles Borins
authored and
Myles Borins
committed
deps: cherry-pick 1383d00 from v8 upstream
Original commit message: tools: fix tickprocessor Cpp symbols on mac Despite man page documentation: -f Display the symbol table of a dynamic library flat (as one file not separate modules). `nm` on mac treats `-f` as a shorthand for `-format`. The `-f` argument does not seem to be required, so just remove it completely. (For `-format` documentation - see `nm --help` on mac). BUG= Review URL: https://codereview.chromium.org/1840633002 Cr-Commit-Position: refs/heads/master@{#35445} Fix: #5903 PR-URL: #6179 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
1 parent ea828ce commit 663cfbc

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

deps/v8/tools/tickprocessor.js

+4-1
Original file line numberDiff line numberDiff line change
@@ -750,8 +750,11 @@ inherits(MacCppEntriesProvider, UnixCppEntriesProvider);
750750
MacCppEntriesProvider.prototype.loadSymbols = function(libName) {
751751
this.parsePos = 0;
752752
libName = this.targetRootFS + libName;
753+
754+
// It seems that in OS X `nm` thinks that `-f` is a format option, not a
755+
// "flat" display option flag.
753756
try {
754-
this.symbols = [os.system(this.nmExec, ['-n', '-f', libName], -1, -1), ''];
757+
this.symbols = [os.system(this.nmExec, ['-n', libName], -1, -1), ''];
755758
} catch (e) {
756759
// If the library cannot be found on this system let's not panic.
757760
this.symbols = '';

0 commit comments

Comments
 (0)