Skip to content

Commit 6788d85

Browse files
TrottBethGriggs
authored andcommitted
doc: revise handling-own-pull-requests text
Simplify and clarify the text of the COLLABORATORS_GUIDE where handling one's own pull requests is concerned. PR-URL: #24583 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
1 parent 8a5b5e1 commit 6788d85

File tree

1 file changed

+11
-13
lines changed

1 file changed

+11
-13
lines changed

COLLABORATOR_GUIDE.md

+11-13
Original file line numberDiff line numberDiff line change
@@ -76,22 +76,20 @@ A pull request is _author ready_ when:
7676
pull request is older than 7 days.
7777
* There are no outstanding review comments.
7878

79-
Please always add the `author ready` label to the PR in that case. Please always
80-
remove it again as soon as the conditions are not met anymore.
79+
Please always add the `author ready` label to the pull request in that case.
80+
Please always remove it again as soon as the conditions are not met anymore.
8181

8282
### Handling own pull requests
8383

84-
When you open a pull request, it is recommended to start a CI right away (see
85-
[testing and CI](#testing-and-ci) for instructions) and to post the link to it
86-
in a comment in the pull request. Starting a new CI after each update is also
87-
recommended (for example, after an additional code change or after rebasing).
88-
89-
As soon as the PR is ready to land, please do so. Landing your own pull requests
90-
allows other Collaborators to focus on other pull requests. If your pull request
91-
is still awaiting the [minimum time to land](#waiting-for-approvals), add the
92-
`author ready` label so other Collaborators know it can land as soon as the time
93-
ends. If instead you wish to land the PR yourself, indicate this intent by using
94-
the "assign yourself" button, to self-assign the PR.
84+
When you open a pull request, [start a CI](#testing-and-ci) right away and post
85+
the link to it in a comment in the pull request. Later, after new code changes
86+
or rebasing, start a new CI.
87+
88+
As soon as the pull request is ready to land, please do so. This allows other
89+
Collaborators to focus on other pull requests. If your pull request is not ready
90+
to land but is [author ready](#author-ready-pull-requests), add the
91+
`author ready` label. If you wish to land the pull request yourself, use the
92+
"assign yourself" link to self-assign it.
9593

9694
## Accepting Modifications
9795

0 commit comments

Comments
 (0)