Skip to content

Commit 6914aea

Browse files
gireeshpunathiladdaleax
authored andcommitted
test: detect all types of aborts in windows
On Windows, 'aborts' are of 2 types, depending on the context: (i) Forced access violation, if --abort-on-uncaught-exception is on which corresponds to exit code 3221225477 (0xC0000005) (ii) raise(SIGABRT) or abort(), which lands up in CRT library calls which corresponds to exit code 3 PR-URL: #12856 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
1 parent c68ebe8 commit 6914aea

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

test/common/index.js

+5-2
Original file line numberDiff line numberDiff line change
@@ -592,10 +592,13 @@ exports.nodeProcessAborted = function nodeProcessAborted(exitCode, signal) {
592592
// or SIGABRT (depending on the compiler).
593593
const expectedSignals = ['SIGILL', 'SIGTRAP', 'SIGABRT'];
594594

595-
// On Windows, v8's base::OS::Abort triggers an access violation,
595+
// On Windows, 'aborts' are of 2 types, depending on the context:
596+
// (i) Forced access violation, if --abort-on-uncaught-exception is on
596597
// which corresponds to exit code 3221225477 (0xC0000005)
598+
// (ii) raise(SIGABRT) or abort(), which lands up in CRT library calls
599+
// which corresponds to exit code 3.
597600
if (exports.isWindows)
598-
expectedExitCodes = [3221225477];
601+
expectedExitCodes = [3221225477, 3];
599602

600603
// When using --abort-on-uncaught-exception, V8 will use
601604
// base::OS::Abort to terminate the process.

0 commit comments

Comments
 (0)