test: change deprecated method to recommended

In non-buffer tests, change usage of the Buffer constructor to one of
the recommended alternatives.

PR-URL: #13649
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Brian White <[email protected]>

Author: Trott

test/parallel/test-stream-pipe-await-drain-push-while-write.js

@@ -17,7 +17,7 @@ const writable = new stream.Writable({
   write: common.mustCall(function(chunk, encoding, cb) {
     if (chunk.length === 32 * 1024) { // first chunk
       const beforePush = readable._readableState.awaitDrain;
-      readable.push(new Buffer(34 * 1024)); // above hwm
+      readable.push(Buffer.alloc(34 * 1024)); // above hwm
       // We should check if awaitDrain counter is increased.
       const afterPush = readable._readableState.awaitDrain;
       assert.strictEqual(afterPush - beforePush, 1,
@@ -34,7 +34,7 @@ const writable = new stream.Writable({
 });
 
 // A readable stream which produces two buffers.
-const bufs = [new Buffer(32 * 1024), new Buffer(33 * 1024)]; // above hwm
+const bufs = [Buffer.alloc(32 * 1024), Buffer.alloc(33 * 1024)]; // above hwm
 const readable = new stream.Readable({
   read: function() {
     while (bufs.length > 0) {

test/parallel/test-stream2-decode-partial.js

@@ -4,8 +4,8 @@ const Readable = require('_stream_readable');
 const assert = require('assert');
 
 let buf = '';
-const euro = new Buffer([0xE2, 0x82, 0xAC]);
-const cent = new Buffer([0xC2, 0xA2]);
+const euro = Buffer.from([0xE2, 0x82, 0xAC]);
+const cent = Buffer.from([0xC2, 0xA2]);
 const source = Buffer.concat([euro, cent]);
 
 const readable = Readable({ encoding: 'utf8' });

test/parallel/test-stream3-cork-end.js

@@ -79,7 +79,7 @@ writeChunks(inputChunks, () => {
     // there was a chunk
     assert.ok(seen);
 
-    const expected = new Buffer(expectedChunks[i]);
+    const expected = Buffer.from(expectedChunks[i]);
     // it was what we expected
     assert.ok(seen.equals(expected));
   }

test/parallel/test-stream3-cork-uncork.js

@@ -74,7 +74,7 @@ writeChunks(inputChunks, () => {
     // there was a chunk
     assert.ok(seen);
 
-    const expected = new Buffer(expectedChunks[i]);
+    const expected = Buffer.from(expectedChunks[i]);
     // it was what we expected
     assert.ok(seen.equals(expected));
   }

test/parallel/test-tls-basic-validations.js

@@ -33,7 +33,7 @@ assert.throws(() => tls.createServer({sessionTimeout: 'abcd'}),
 assert.throws(() => tls.createServer({ticketKeys: 'abcd'}),
               /TypeError: Ticket keys must be a buffer/);
 
-assert.throws(() => tls.createServer({ticketKeys: new Buffer(0)}),
+assert.throws(() => tls.createServer({ticketKeys: Buffer.alloc(0)}),
               /TypeError: Ticket keys length must be 48 bytes/);
 
 assert.throws(() => tls.createSecurePair({}),

test/parallel/test-zlib-bytes-read.js

@@ -28,7 +28,7 @@ for (const method of [
   ['createDeflateRaw', 'createInflateRaw', true]
 ]) {
   let compWriter;
-  let compData = new Buffer(0);
+  let compData = Buffer.alloc(0);
 
   const comp = zlib[method[0]]();
   comp.on('data', function(d) {
@@ -44,7 +44,7 @@ for (const method of [
 
     {
       let decompWriter;
-      let decompData = new Buffer(0);
+      let decompData = Buffer.alloc(0);
 
       const decomp = zlib[method[1]]();
       decomp.on('data', function(d) {
@@ -66,10 +66,10 @@ for (const method of [
 
     // Some methods should allow extra data after the compressed data
     if (method[2]) {
-      const compDataExtra = Buffer.concat([compData, new Buffer('extra')]);
+      const compDataExtra = Buffer.concat([compData, Buffer.from('extra')]);
 
       let decompWriter;
-      let decompData = new Buffer(0);
+      let decompData = Buffer.alloc(0);
 
       const decomp = zlib[method[1]]();
       decomp.on('data', function(d) {

test/parallel/test-zlib-from-gzip-with-trailing-garbage.js

@@ -9,7 +9,7 @@ const zlib = require('zlib');
 let data = Buffer.concat([
   zlib.gzipSync('abc'),
   zlib.gzipSync('def'),
-  Buffer(10).fill(0)
+  Buffer.alloc(10)
 ]);
 
 assert.strictEqual(zlib.gunzipSync(data).toString(), 'abcdef');
@@ -28,8 +28,8 @@ zlib.gunzip(data, common.mustCall((err, result) => {
 data = Buffer.concat([
   zlib.gzipSync('abc'),
   zlib.gzipSync('def'),
-  Buffer([0x1f, 0x8b, 0xff, 0xff]),
-  Buffer(10).fill(0)
+  Buffer.from([0x1f, 0x8b, 0xff, 0xff]),
+  Buffer.alloc(10)
 ]);
 
 assert.throws(
@@ -49,7 +49,7 @@ zlib.gunzip(data, common.mustCall((err, result) => {
 data = Buffer.concat([
   zlib.gzipSync('abc'),
   zlib.gzipSync('def'),
-  Buffer([0x1f, 0x8b, 0xff, 0xff])
+  Buffer.from([0x1f, 0x8b, 0xff, 0xff])
 ]);
 
 assert.throws(

test/parallel/test-zlib-sync-no-event.js

@@ -10,7 +10,7 @@ const message = 'Come on, Fhqwhgads.';
 const zipper = new zlib.Gzip();
 zipper.on('close', shouldNotBeCalled);
 
-const buffer = new Buffer(message);
+const buffer = Buffer.from(message);
 const zipped = zipper._processChunk(buffer, zlib.constants.Z_FINISH);
 
 const unzipper = new zlib.Gunzip();