Skip to content

Commit 69c0841

Browse files
Trottaddaleax
authored andcommitted
test: refactor pummel/test-net-connect-econnrefused
* Reduce ROUNDS and ATTEMPTS_PER_ROUND by half to avoid spurious test failures as a result of side effects from other tests. (For my local setup, test-keep-alive seems to cause this test to fail with ETIMEDOUT and/or EADDRNOTAVAIL. It would seem to be a result of throttling. Reducing the pummel-iness of that test and this one seems to solve the problem.) * Apply capitalization and punctuation to comment. PR-URL: #25485 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
1 parent 817b44d commit 69c0841

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

test/pummel/test-net-connect-econnrefused.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,14 @@
2020
// USE OR OTHER DEALINGS IN THE SOFTWARE.
2121

2222
'use strict';
23-
// verify that connect reqs are properly cleaned up
23+
// Verify that connect reqs are properly cleaned up.
2424

2525
const common = require('../common');
2626
const assert = require('assert');
2727
const net = require('net');
2828

29-
const ROUNDS = 10;
30-
const ATTEMPTS_PER_ROUND = 100;
29+
const ROUNDS = 5;
30+
const ATTEMPTS_PER_ROUND = 50;
3131
let rounds = 1;
3232
let reqs = 0;
3333

0 commit comments

Comments
 (0)