Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 6a113da

Browse files
addaleaxMylesBorins
authored andcommittedMay 22, 2018
test: rename and document tls test
Add a short description and one question to a TLS test. Also, rename it since the previous name might unintentionally evoke connotations to an internet meme that would generally not be considered appropriate in our context. PR-URL: #20820 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
1 parent 545a9d8 commit 6a113da

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed
 

‎test/parallel/test-tls-two-cas-one-string.js ‎test/parallel/test-tls-multiple-cas-as-string.js

+5
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@ const common = require('../common');
44
if (!common.hasCrypto)
55
common.skip('missing crypto');
66

7+
// Verify that multiple CA certificates can be provided, and that for
8+
// convenience that can also be in newline-separated strings.
9+
710
const tls = require('tls');
811
const fixtures = require('../common/fixtures');
912

@@ -30,6 +33,8 @@ function test(ca, next) {
3033
}
3134
}
3235

36+
// `ca1` is not actually necessary for the certificate validation -- maybe
37+
// the fixtures should be written in a way that requires it?
3338
const array = [ca1, ca2];
3439
const string = `${ca1}\n${ca2}`;
3540
test(array, common.mustCall(() => test(string)));

0 commit comments

Comments
 (0)
Please sign in to comment.