Skip to content

Commit 6a1275d

Browse files
addaleaxjasnell
authored andcommitted
src: add missing "http_parser.h" include
In 9d52222 the indirect "http_parser.h" include was removed, which made `NODE_STRINGIFY()` fail silently for the http parser version in `process.versions`. PR-URL: #12464 Fixes: #12463 Ref: #12366 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Brian White <[email protected]>
1 parent 0584aeb commit 6a1275d

File tree

2 files changed

+9
-0
lines changed

2 files changed

+9
-0
lines changed

src/node.cc

+1
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@
5454
#include "env.h"
5555
#include "env-inl.h"
5656
#include "handle_wrap.h"
57+
#include "http_parser.h"
5758
#include "req-wrap.h"
5859
#include "req-wrap-inl.h"
5960
#include "string_bytes.h"

test/parallel/test-process-versions.js

+8
Original file line numberDiff line numberDiff line change
@@ -20,3 +20,11 @@ expected_keys.sort();
2020
const actual_keys = Object.keys(process.versions).sort();
2121

2222
assert.deepStrictEqual(actual_keys, expected_keys);
23+
24+
assert(/^\d+\.\d+\.\d+(-.*)?$/.test(process.versions.ares));
25+
assert(/^\d+\.\d+\.\d+(-.*)?$/.test(process.versions.http_parser));
26+
assert(/^\d+\.\d+\.\d+(-.*)?$/.test(process.versions.node));
27+
assert(/^\d+\.\d+\.\d+(-.*)?$/.test(process.versions.uv));
28+
assert(/^\d+\.\d+\.\d+(-.*)?$/.test(process.versions.zlib));
29+
assert(/^\d+\.\d+\.\d+\.\d+$/.test(process.versions.v8));
30+
assert(/^\d+$/.test(process.versions.modules));

0 commit comments

Comments
 (0)