Skip to content

Commit 6ade7f3

Browse files
committed
src: update --inspect hint text
* Removes "experimental" warning. * Prints ws://_ip_:_port_:/_uuid_ for all IDs. * Refers to nodejs.org guide for more details. PR-URL: #11207 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]>
1 parent e48d58b commit 6ade7f3

File tree

2 files changed

+5
-12
lines changed

2 files changed

+5
-12
lines changed

src/inspector_socket_server.cc

+3-10
Original file line numberDiff line numberDiff line change
@@ -81,19 +81,12 @@ void PrintDebuggerReadyMessage(const std::string& host,
8181
if (out == NULL) {
8282
return;
8383
}
84-
fprintf(out,
85-
"Debugger listening on %s:%d.\n",
86-
host.c_str(), port);
87-
if (ids.size() == 1)
88-
fprintf(out, "To start debugging, open the following URL in Chrome:\n");
89-
if (ids.size() > 1)
90-
fprintf(out, "To start debugging, open the following URLs in Chrome:\n");
9184
for (const std::string& id : ids) {
92-
fprintf(out,
93-
" chrome-devtools://devtools/bundled/inspector.html?"
94-
"experiments=true&v8only=true&ws=%s\n",
85+
fprintf(out, "Debugger listening on ws://%s\n",
9586
GetWsUrl(host, port, id).c_str());
9687
}
88+
fprintf(out, "For help see %s\n",
89+
"https://nodejs.org/en/docs/inspector");
9790
fflush(out);
9891
}
9992

test/inspector/inspector-helper.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -461,11 +461,11 @@ exports.startNodeForInspectorTest = function(callback,
461461
clearTimeout(timeoutId);
462462
console.log('[err]', text);
463463
if (found) return;
464-
const match = text.match(/Debugger listening on .*:(\d+)/);
464+
const match = text.match(/Debugger listening on ws:\/\/(.+):(\d+)\/(.+)/);
465465
found = true;
466466
child.stderr.removeListener('data', dataCallback);
467467
assert.ok(match, text);
468-
callback(new Harness(match[1], child));
468+
callback(new Harness(match[2], child));
469469
});
470470

471471
child.stderr.on('data', dataCallback);

0 commit comments

Comments
 (0)