Skip to content

Commit 6c7d8b4

Browse files
refackjasnell
authored andcommitted
build: spawn make test-ci with -j1
All the sub targets have internal parallelism, so no performance loss. Also `make` doesn't to a good enough job of combining the output streams, or eliminate races. PR-URL: #23733 Fixes: #22006 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
1 parent 512faa8 commit 6c7d8b4

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

Diff for: Makefile

+4-1
Original file line numberDiff line numberDiff line change
@@ -480,8 +480,11 @@ build-ci:
480480
# of tests. See `test-ci-native` and `test-ci-js`.
481481
# - node-test-commit-linux-coverage: where the build and the tests need
482482
# to be instrumented, see `coverage`.
483+
#
484+
# Using -j1 as the sub target in `test-ci` already have internal parallelism.
485+
# Refs: https://github.com/nodejs/node/pull/23733
483486
run-ci: build-ci
484-
$(MAKE) test-ci
487+
$(MAKE) test-ci -j1
485488

486489
test-release: test-build
487490
$(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=$(BUILDTYPE_LOWER)

0 commit comments

Comments
 (0)