Skip to content

Commit 6c9a84b

Browse files
TrottMyles Borins
authored and
Myles Borins
committed
doc: add ctc-review label information
PR-URL: #9072 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
1 parent e9d5cd7 commit 6c9a84b

File tree

3 files changed

+13
-9
lines changed

3 files changed

+13
-9
lines changed

COLLABORATOR_GUIDE.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ continuous integration tests on the
8484
### Involving the CTC
8585

8686
Collaborators may opt to elevate pull requests or issues to the CTC for
87-
discussion by assigning the ***ctc-agenda*** tag. This should be done
87+
discussion by assigning the `ctc-review` label. This should be done
8888
where a pull request:
8989

9090
- has a significant impact on the codebase,

GOVERNANCE.md

+8-6
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ modification. See [Consensus Seeking Process](#consensus-seeking-process) below
4242
for further detail on the consensus model used for governance.
4343

4444
Collaborators may opt to elevate significant or controversial modifications to
45-
the CTC by assigning the ***ctc-agenda*** tag to a pull request or issue. The
45+
the CTC by assigning the `ctc-review` label to a pull request or issue. The
4646
CTC should serve as the final arbiter where required.
4747

4848
For the current list of Collaborators, see the project
@@ -98,7 +98,7 @@ members affiliated with the over-represented employer(s).
9898
Typical activities of a CTC member include:
9999

100100
* attending the weekly meeting
101-
* commenting on the weekly CTC meeting issue and issues labeled `ctc-agenda`
101+
* commenting on the weekly CTC meeting issue and issues labeled `ctc-review`
102102
* participating in CTC email threads
103103
* volunteering for tasks that arise from CTC meetings and related discussions
104104
* other activities (beyond those typical of Collaborators) that facilitate the
@@ -120,10 +120,12 @@ The intention of the agenda is not to approve or review all patches.
120120
That should happen continuously on GitHub and be handled by the larger
121121
group of Collaborators.
122122

123-
Any community member or contributor can ask that something be added to
124-
the next meeting's agenda by logging a GitHub issue. Any Collaborator,
125-
CTC member, or the moderator can add the item to the agenda by adding
126-
the ***ctc-agenda*** tag to the issue.
123+
Any community member or contributor can ask that something be reviewed
124+
by the CTC by logging a GitHub issue. Any Collaborator, CTC member, or the
125+
moderator can bring the issue to the CTC's attention by applying the
126+
`ctc-review` label. If consensus-seeking among CTC members fails for a
127+
particular issue, it may be added to the CTC meeting agenda by adding the
128+
`ctc-agenda` label.
127129

128130
Prior to each CTC meeting, the moderator will share the agenda with
129131
members of the CTC. CTC members can also add items to the agenda at the

doc/onboarding.md

+4-2
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,8 @@ onboarding session.
6262
* Labels:
6363
* There is [a bot](https://github.com/nodejs-github-bot/github-bot) that applies subsystem labels (for example, `doc`, `test`, `assert`, or `buffer`) so that we know what parts of the code base the pull request modifies. It is not perfect, of course. Feel free to apply relevant labels and remove irrelevant labels from pull requests and issues.
6464
* [**See "Labels"**](./onboarding-extras.md#labels)
65-
* Use the `ctc-agenda` if a topic is controversial or isn't coming to a conclusion after an extended time.
65+
* Use the `ctc-review` label if a topic is controversial or isn't coming to
66+
a conclusion after an extended time.
6667
* `semver-{minor,major}`:
6768
* If a change has the remote *chance* of breaking something, use `semver-major`
6869
* When adding a semver label, add a comment explaining why you're adding it. Do it right away so you don't forget!
@@ -145,7 +146,8 @@ onboarding session.
145146
the objection is addressed. The options for such a situation include:
146147
* Engaging those with objections to determine a viable path forward;
147148
* Altering the pull request to address the objections;
148-
* Escalating the discussion to the CTC using the `ctc-agenda` label. This should only be done after other options have been exhausted.
149+
* Escalating the discussion to the CTC using the `ctc-review` label. This
150+
should only be done after the previous options have been exhausted.
149151

150152
* Wait before merging non-trivial changes.
151153
* 48 hours during the week and 72 hours on weekends.

0 commit comments

Comments
 (0)