readline: clean up event listener in onNewListener

gibfahn · gibfahn · commit 6d273763f714 · 2017-05-28T14:32:26.000+01:00
Once the Readline interface is closed, the 'data' event listener should be removed. Refs: #9447 (comment)
diff --git a/lib/readline.js b/lib/readline.js
@@ -1030,6 +1030,7 @@ function emitKeypressEvents(stream, iface) {
   function onNewListener(event) {
     if (event === 'keypress') {
       stream.on('data', onData);
+      iface.once('close', () => { stream.removeListener('data', onData); });
       stream.removeListener('newListener', onNewListener);
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -1030,6 +1030,7 @@ function emitKeypressEvents(stream, iface) {`
`1030`	`1030`	`function onNewListener(event) {`
`1031`	`1031`	`if (event === 'keypress') {`
`1032`	`1032`	`stream.on('data', onData);`
	`1033`	`+ iface.once('close', () => { stream.removeListener('data', onData); });`
`1033`	`1034`	`stream.removeListener('newListener', onNewListener);`
`1034`	`1035`	`}`
`1035`	`1036`	`}`