Skip to content

Commit 6e942e7

Browse files
committed
fs: make fs_event_wrap binding internal
PR-URL: #22480 Refs: #22160 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent dca2f98 commit 6e942e7

File tree

4 files changed

+5
-3
lines changed

4 files changed

+5
-3
lines changed

Diff for: lib/internal/bootstrap/node.js

+1
Original file line numberDiff line numberDiff line change
@@ -348,6 +348,7 @@
348348
// internalBinding.
349349
const internalBindingWhitelist =
350350
new SafeSet([
351+
'fs_event_wrap',
351352
'uv',
352353
'http_parser',
353354
'process_wrap',

Diff for: lib/internal/fs/watchers.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
11
'use strict';
22

33
const errors = require('internal/errors');
4+
const { internalBinding } = require('internal/bootstrap/loaders');
45
const {
56
kFsStatsFieldsLength,
67
StatWatcher: _StatWatcher
78
} = process.binding('fs');
8-
const { FSEvent } = process.binding('fs_event_wrap');
9+
const { FSEvent } = internalBinding('fs_event_wrap');
910
const { EventEmitter } = require('events');
1011
const {
1112
getStatsFromBinding,

Diff for: src/fs_event_wrap.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -235,4 +235,4 @@ void FSEventWrap::OnEvent(uv_fs_event_t* handle, const char* filename,
235235
} // anonymous namespace
236236
} // namespace node
237237

238-
NODE_BUILTIN_MODULE_CONTEXT_AWARE(fs_event_wrap, node::FSEventWrap::Initialize)
238+
NODE_MODULE_CONTEXT_AWARE_INTERNAL(fs_event_wrap, node::FSEventWrap::Initialize)

Diff for: test/sequential/test-async-wrap-getasyncid.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ function testInitialized(req, ctor_name) {
8888

8989

9090
{
91-
const FSEvent = process.binding('fs_event_wrap').FSEvent;
91+
const FSEvent = internalBinding('fs_event_wrap').FSEvent;
9292
testInitialized(new FSEvent(), 'FSEvent');
9393
}
9494

0 commit comments

Comments
 (0)