tty: fix 'resize' event regression

It's not wholly clear what commit introduced the regression but between
v8.4.0 and v8.5.0 the 'resize' event stopped getting emitted when the
tty was resized.

The SIGWINCH event listener apparently was being installed before the
support code for `process.on('SIGWINCH', ...)` was.  Fix that by moving
said support code to real early in the bootstrap process.

This commit also seems to fix a Windows-only "write EINVAL" error for
reasons even less well-understood...

Fixes: #16141
Fixes: #16194
PR-URL: #16225
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>

Author: bnoordhuis

lib/internal/bootstrap_node.js

@@ -29,6 +29,7 @@
 
     const _process = NativeModule.require('internal/process');
     _process.setupConfig(NativeModule._source);
+    _process.setupSignalHandlers();
     NativeModule.require('internal/process/warning').setup();
     NativeModule.require('internal/process/next_tick').setup();
     NativeModule.require('internal/process/stdio').setup();
@@ -51,7 +52,6 @@
     _process.setup_cpuUsage();
     _process.setupMemoryUsage();
     _process.setupKillAndExit();
-    _process.setupSignalHandlers();
     if (global.__coverage__)
       NativeModule.require('internal/process/write-coverage').setup();
 

test/pseudo-tty/pseudo-tty.status

@@ -3,3 +3,8 @@ prefix pseudo-tty
 [$system==aix]
 # being investigated under https://github.com/nodejs/node/issues/9728
 test-tty-wrap              : FAIL, PASS
+
+[$system==solaris]
+# https://github.com/nodejs/node/pull/16225 - `ioctl(fd, TIOCGWINSZ)` seems
+# to fail with EINVAL on SmartOS when `fd` is a pty from python's pty module.
+test-tty-stdout-resize     : FAIL, PASS

test/pseudo-tty/test-tty-stdout-resize.js

@@ -0,0 +1,11 @@
+'use strict';
+const { mustCall } = require('../common');
+const { notStrictEqual } = require('assert');
+
+// tty.WriteStream#_refreshSize() only emits the 'resize' event when the
+// window dimensions change.  We cannot influence that from the script
+// but we can set the old values to something exceedingly unlikely.
+process.stdout.columns = 9001;
+process.stdout.on('resize', mustCall());
+process.kill(process.pid, 'SIGWINCH');
+setImmediate(mustCall(() => notStrictEqual(process.stdout.columns, 9001)));