Skip to content

Commit 6feea08

Browse files
alemuresitaloacasas
authored andcommitted
buffer: preallocate array with buffer length
Because the final array length is known, it's better to allocate its final length at initialization time to avoid future reallocations. Also add an explicit buffer length greater than 0 comparison so it's more readable, avoids the internal ToBoolean call and follows the standard Node.js API format (as it can be checked in other similar structures where 'length > 0' is preferred over 'length') PR-URL: #11733 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Brian White <[email protected]>
1 parent a703bde commit 6feea08

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

lib/buffer.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -799,8 +799,8 @@ Buffer.prototype.write = function(string, offset, length, encoding) {
799799

800800

801801
Buffer.prototype.toJSON = function() {
802-
if (this.length) {
803-
const data = [];
802+
if (this.length > 0) {
803+
const data = new Array(this.length);
804804
for (var i = 0; i < this.length; ++i)
805805
data[i] = this[i];
806806
return { type: 'Buffer', data };

0 commit comments

Comments
 (0)