Skip to content

Commit 70a727e

Browse files
TrottMylesBorins
authored andcommitted
doc: improve PR-review paragraph in CONTRIBUTING.md
* Remove redundant "blocking it or stopping it" as blocking and stopping are the same thing in this case. * Make another sentence less wordy. Fix incorrect verb conjugation. Break into two clear sentences. PR-URL: #17931 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
1 parent 2691e46 commit 70a727e

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

CONTRIBUTING.md

+5-6
Original file line numberDiff line numberDiff line change
@@ -602,12 +602,11 @@ your name on it. Congratulations and thanks for your contribution!
602602
All Node.js contributors who choose to review and provide feedback on Pull
603603
Requests have a responsibility to both the project and the individual making the
604604
contribution. Reviews and feedback must be helpful, insightful, and geared
605-
towards improving the contribution as opposed to simply blocking it or
606-
stopping it. If there are reasons why you feel the PR should not land, explain
607-
what those are. Do not expect to be able to block a Pull Request from advancing
608-
simply because you say "No" without giving an explanation. It is also important
609-
to be open to having your mind changed, and to being open to working with the
610-
contributor to make the Pull Request better.
605+
towards improving the contribution as opposed to simply blocking it. If there
606+
are reasons why you feel the PR should not land, explain what those are. Do not
607+
expect to be able to block a Pull Request from advancing simply because you say
608+
"No" without giving an explanation. Be open to having your mind changed. Be open
609+
to working with the contributor to make the Pull Request better.
611610

612611
Reviews that are dismissive or disrespectful of the contributor or any other
613612
reviewers are strictly counter to the [Code of Conduct][].

0 commit comments

Comments
 (0)