Skip to content

Commit 7135822

Browse files
danbevtargos
authored andcommitted
build: make tools/doc/node_modules non-phony
This commit makes the target tools/doc/node_modules a non-phony target and also adds tools/doc/package.json as a prerequisite to it to avoid running it unnecessary. This is currently causing the target test/addons/.docbuildstamp to be always be executed as it has tools/doc/node_modules as a prerequisite. PR-URL: #22189 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Sam Ruby <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
1 parent 3baeb82 commit 7135822

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

Makefile

+1-2
Original file line numberDiff line numberDiff line change
@@ -1066,8 +1066,7 @@ lint-md-build: tools/remark-cli/node_modules \
10661066
tools/doc/node_modules \
10671067
tools/remark-preset-lint-node/node_modules
10681068

1069-
.PHONY: tools/doc/node_modules
1070-
tools/doc/node_modules:
1069+
tools/doc/node_modules: tools/doc/package.json
10711070
ifeq ($(node_use_openssl),true)
10721071
cd tools/doc && $(call available-node,$(run-npm-install))
10731072
else

0 commit comments

Comments
 (0)