Skip to content

Commit 7153f96

Browse files
bnoordhuisFishrock123
authored andcommitted
build: unbreak -prof, disable PIE on OS X
Commit 204f3a8 ("build: Bump MACOSX_DEPLOYMENT_TARGET to 10.7") unwittingly turned on new ASLR features that make `-prof` unusable for profiling C++ code, breaking `test/parallel/test-tick-processor.js` in the process. Build with `-Wl,-no_pie` for now. Fixes: #5903 PR-URL: #6453 Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
1 parent 089362f commit 7153f96

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

common.gypi

+6-1
Original file line numberDiff line numberDiff line change
@@ -325,7 +325,12 @@
325325
},
326326
'target_conditions': [
327327
['_type!="static_library"', {
328-
'xcode_settings': {'OTHER_LDFLAGS': ['-Wl,-search_paths_first']},
328+
'xcode_settings': {
329+
'OTHER_LDFLAGS': [
330+
'-Wl,-no_pie',
331+
'-Wl,-search_paths_first',
332+
],
333+
},
329334
}],
330335
],
331336
'conditions': [

0 commit comments

Comments
 (0)