Skip to content

Commit 72983d2

Browse files
dmabuptaddaleax
authored andcommitted
test: skip some binding tests on IBMi PASE
IBMi PASE Node.js always links to shared openssl and zlib libraries. So skip the static binding tests. PR-URL: #31967 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
1 parent 30d55a3 commit 72983d2

File tree

3 files changed

+20
-3
lines changed

3 files changed

+20
-3
lines changed

test/addons/addon.status

+4
Original file line numberDiff line numberDiff line change
@@ -9,3 +9,7 @@ prefix addons
99
[$arch==arm]
1010
# https://github.com/nodejs/node/issues/30786
1111
openssl-binding/test: PASS,FLAKY
12+
13+
[$system==ibmi]
14+
openssl-binding/test: SKIP
15+
zlib-binding/test: SKIP

test/addons/openssl-binding/binding.gyp

+6-1
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,13 @@
33
{
44
'target_name': 'binding',
55
'includes': ['../common.gypi'],
6+
'variables': {
7+
# Skip this building on IBM i.
8+
'aix_variant_name': '<!(uname -s)',
9+
},
610
'conditions': [
7-
['node_use_openssl=="true"', {
11+
['node_use_openssl=="true" and '
12+
'"<(aix_variant_name)"!="OS400"', {
813
'sources': ['binding.cc'],
914
'include_dirs': ['../../../deps/openssl/openssl/include'],
1015
}],

test/addons/zlib-binding/binding.gyp

+10-2
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,16 @@
22
'targets': [
33
{
44
'target_name': 'binding',
5-
'sources': ['binding.cc'],
6-
'include_dirs': ['../../../deps/zlib'],
5+
'variables': {
6+
# Skip this building on IBM i.
7+
'aix_variant_name': '<!(uname -s)',
8+
},
9+
'conditions': [
10+
[ '"<(aix_variant_name)"!="OS400"', {
11+
'sources': ['binding.cc'],
12+
'include_dirs': ['../../../deps/zlib'],
13+
}],
14+
],
715
'includes': ['../common.gypi'],
816
},
917
]

0 commit comments

Comments
 (0)