Skip to content

Commit 73f2dab

Browse files
Masashi HiranoMylesBorins
Masashi Hirano
authored andcommitted
test: fix common.canCreateSymLink() on non-Windows
test/common/README.md indicates that canCreateSymlink() always returns true on non-Windows platforms. However, prior to this commit, undefined was being returned. This commit aligns the implementation with the docs by returning true. PR-URL: #20511 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
1 parent 380dfe4 commit 73f2dab

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

test/common/index.js

+2
Original file line numberDiff line numberDiff line change
@@ -518,6 +518,8 @@ exports.canCreateSymLink = function() {
518518
return false;
519519
}
520520
}
521+
// On non-Windows platforms, this always returns `true`
522+
return true;
521523
};
522524

523525
exports.getCallSite = function getCallSite(top) {

0 commit comments

Comments
 (0)