Skip to content

Commit 73f490a

Browse files
refackMylesBorins
authored andcommitted
doc,meta: assign PR semantics
PR-URL: #23292 Refs: #23249 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]>
1 parent 2ddf867 commit 73f490a

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

COLLABORATOR_GUIDE.md

+5-1
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,8 @@ As soon as the PR is ready to land, please do so. Landing your own pull requests
100100
allows other Collaborators to focus on other pull requests. If your pull request
101101
is still awaiting the [minimum time to land](#waiting-for-approvals), add the
102102
`author ready` label so other Collaborators know it can land as soon as the time
103-
ends.
103+
ends. If instead you wish to land the PR yourself, indicate this intent by using
104+
the "assign yourself" button, to self-assign the PR.
104105

105106
## Accepting Modifications
106107

@@ -501,6 +502,9 @@ The TSC should serve as the final arbiter where required.
501502

502503
## Landing Pull Requests
503504

505+
1. Avoid landing PRs that are assigned to someone else. Authors who wish to land
506+
their own PRs will self-assign them, or delegate to someone else. If in
507+
doubt, ask the assignee whether it is okay to land.
504508
1. Never use GitHub's green ["Merge Pull Request"][] button. Reasons for not
505509
using the web interface button:
506510
* The "Create a merge commit" method will add an unnecessary merge commit.

0 commit comments

Comments
 (0)