Skip to content

Commit 74046ce

Browse files
lpincatargos
authored andcommitted
http2: do not override the allowHalfOpen option
The constructors of `tls.Server` and `Http2Server` call the super constructors without options so the `allowHalfOpen` option is never used regardless of its value. PR-URL: #27623 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent c33e834 commit 74046ce

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

lib/internal/http2/core.js

-1
Original file line numberDiff line numberDiff line change
@@ -2643,7 +2643,6 @@ function connectionListener(socket) {
26432643
function initializeOptions(options) {
26442644
assertIsObject(options, 'options');
26452645
options = { ...options };
2646-
options.allowHalfOpen = true;
26472646
assertIsObject(options.settings, 'options.settings');
26482647
options.settings = { ...options.settings };
26492648

0 commit comments

Comments
 (0)