Skip to content

Commit 742a456

Browse files
targosMylesBorins
authored andcommitted
build: fix test-v8 target
Clean the deps/v8 directory before rebuilding node for the hash seed test. It is necessary to avoid the script added in [1] to use ignored files while generating `node-debug-support.cc`. [1]: #14901 PR-URL: #17269 Fixes: nodejs/node-v8#26 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
1 parent 87c885b commit 742a456

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

Makefile

+1
Original file line numberDiff line numberDiff line change
@@ -501,6 +501,7 @@ test-v8: v8
501501
--no-presubmit \
502502
--shell-dir=$(PWD)/deps/v8/out/$(V8_ARCH).$(BUILDTYPE_LOWER) \
503503
$(TAP_V8)
504+
git clean -fdxq -- deps/v8
504505
@echo Testing hash seed
505506
$(MAKE) test-hash-seed
506507

0 commit comments

Comments
 (0)