Skip to content

Commit 7510493

Browse files
committed
module: fix initial ModuleWrap with non-string source
1 parent b46bbf2 commit 7510493

File tree

4 files changed

+21
-1
lines changed

4 files changed

+21
-1
lines changed

lib/internal/modules/esm/translators.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ translators.set('module', async function moduleStrategy(url) {
8585
source, { url, format: 'module' }, defaultTransformSource));
8686
maybeCacheSourceMap(url, source);
8787
debug(`Translating StandardModule ${url}`);
88-
const module = new ModuleWrap(url, undefined, source, 0, 0);
88+
const module = new ModuleWrap(url, undefined, `${source}`, 0, 0);
8989
moduleWrap.callbackMap.set(module, {
9090
initializeImportMeta,
9191
importModuleDynamically,
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
export function transformSource() {
2+
return {
3+
source: {
4+
boom: true
5+
}
6+
};
7+
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
// Flags: --experimental-loader ./test/fixtures/es-module-loaders/loader-invalid-transform-source.mjs
2+
// Fixes: https://github.com/nodejs/node/issues/33441
3+
import '../common/index.mjs';
4+
import 'fs';
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
(node:*) ExperimentalWarning: --experimental-loader is an experimental feature. This feature could change at any time
2+
(Use `node --trace-warnings ...` to show where the warning was created)
3+
file:///*/test/message/esm-invalid-transform-source.mjs:1
4+
[object Object]
5+
^^^^^^
6+
7+
SyntaxError: Unexpected identifier
8+
at Loader.moduleStrategy (internal/modules/esm/translators.js:*:*)
9+
at async link (internal/modules/esm/module_job.js:*:*)

0 commit comments

Comments
 (0)