Skip to content

Commit 756f63e

Browse files
bmeurertargos
authored andcommittedJul 19, 2018
src: prepare for V8 Swallowed Rejection Hook
This is done in preparation for landing https://chromium-review.googlesource.com/c/v8/v8/+/1126099 on the V8 side, which extends the existing PromiseRejectEvent mechanism with new hooks for reject/resolve after a Promise was previously resolved already. Refs: nodejs/promises-debugging#8 Design: https://goo.gl/2stLUY PR-URL: #21838 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yang Guo <[email protected]> Reviewed-By: Benedikt Meurer <[email protected]>
1 parent df08779 commit 756f63e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed
 

‎src/bootstrapper.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ void PromiseRejectCallback(PromiseRejectMessage message) {
6969
callback = env->promise_reject_handled_function();
7070
value = Undefined(isolate);
7171
} else {
72-
UNREACHABLE();
72+
return;
7373
}
7474

7575
Local<Value> args[] = { promise, value };

0 commit comments

Comments
 (0)